plugin-php icon indicating copy to clipboard operation
plugin-php copied to clipboard
verified publisher icon prettier

Imporve doc print

Open fisker opened this issue 3 years ago • 2 comments

I was going to help remove the deprecated concat command, but I found we are still running tests with [email protected], are we going to continue to support old version?

Anyway, eslint-plugin-prettier-doc should be useful whenever you decide to remove concat().

Changes in this PR are problems caught by other rules in eslint-plugin-prettier-doc.

fisker avatar Feb 08 '22 05:02 fisker

Wow nice, I didn't know about eslint-plugin-prettier-doc yet - thanks @fisker! We're still on prettier 2.1 just because we didn't get to look at the formatting changes newer releases introduced yet (see https://github.com/prettier/plugin-php/runs/5057210765?check_suite_focus=true). It would be great to get that dependency updated.

czosel avatar Feb 08 '22 09:02 czosel

It is probably time to upgrade to more modern prettier and drop support for older nodejs versions. I tried this somewhat recently, and there is a lot to fix, this is a great first step.

cseufert avatar Jun 23 '22 22:06 cseufert

@alexander-akait done :tada:

czosel avatar Mar 12 '23 17:03 czosel

This looks great.

cseufert avatar Mar 14 '23 02:03 cseufert

It took us long enough to get this merged 🙈 thanks again @fisker!

czosel avatar Mar 14 '23 06:03 czosel

Released in v0.19.4 :tada:

czosel avatar Mar 14 '23 11:03 czosel