presto-admin icon indicating copy to clipboard operation
presto-admin copied to clipboard

Added support for expanding environment variables in configuration files.

Open gorkemmulayim opened this issue 7 years ago • 2 comments

Closes #329

Added support for expanding environment variables in configuration files.

For example:

Given an example node.properties files

node.environment=${ENV}
node.data-dir=/var/lib/presto/data
node.launcher-log-file=/var/log/presto/launcher.log
node.server-log-file=/var/log/presto/server.log
catalog.config-dir=/etc/presto/catalog
plugin.dir=/usr/lib/presto/lib/plugin

application can now resolve variable defined by ${ENV} from environment variables.

  • Definitions of a variable are ${variableName} or $variableName. In addition to this, on Windows, %variableName% definition is supported as well.
  • In case of an invalid or non existing variable definition, variable is left unchanged.

gorkemmulayim avatar Feb 19 '19 14:02 gorkemmulayim

@RootG Please ping once you done with your changes.

kokosing avatar Mar 04 '19 09:03 kokosing

this PR seems quite old. Is anyone going to revive it? @kokosing

ddcprg avatar Sep 17 '21 16:09 ddcprg