subexec icon indicating copy to clipboard operation
subexec copied to clipboard

Deprecate this gem

Open janko opened this issue 11 years ago • 0 comments

This gem doesn't have a good implementation:

  • It uses sleep 0.01 for waiting for the command to finish, which is very CPU heavy and definitively not the right way (you can do the waiting with IO.pipe, as shown in this blog post)
  • It captures stdout and stderr both in the same string, which is unusable when we actually care which is which

Most-importantly, there is already an implementation of this gem in the Ruby standard library, called open3. The Open3.catpure3 does everything that this gem does, but better and with automatic Windows support and similar. It doesn't however work on JRuby, because they didn't implement it, but they're fixing it.

janko avatar Oct 26 '14 10:10 janko