subexec icon indicating copy to clipboard operation
subexec copied to clipboard

Unusable under JRuby + Windows

Open tom-pryor opened this issue 13 years ago • 1 comments

Using RUBY_PLATFORM under JRuby always returns java therefore this should never be used to detect the OS under JRuby.

This causes problems under Windows and JRuby because subexec detects JRuby successfully so it calls exec. However, exec then does if !(RUBY_PLATFORM =~ /win32|mswin|mingw/).nil? which is totally pointless under JRuby since RUBY_PLATFORM will always return java so it will always execute self.output = LANG=#{lang} && export $LANG && #{command} 2>&1`` regardless of the underlying OS. Executing this on Windows is going to fail instantly because it does not understand LANG=. @gissues:{"order":40,"status":"backlog"}

tom-pryor avatar Dec 28 '12 19:12 tom-pryor

OK just ran into this myself

'LANG' is not recognized as an internal or external command, operable program or batch file.

This https://github.com/rdp/subexec/commit/4c08e8dbc6280986bf45032e50e683ea6fa127f2

was able to help at least with v. 0.2.2 [unfortunately I couldn't seem to quite figure out how to convince bundler to use the right version of rspec, so I know that did help me, I wasn't able to run the unit tests against it]. HTH. -roger-

rdp avatar May 06 '14 23:05 rdp