premake
Regression: commit 5b3497937b81e135001ac5cfe9b41cdcefa57531 breaks `premake5 package master source`
Since commit 5b3497937b81e135001ac5cfe9b41cdcefa57531, premake5 package master source does not generate Visual Studio solution files for x64 in the packaged source. Instead of generating projects for Win32/x86 and x64/amd64, it only generated them for Win32.
The offending hunk is https://github.com/premake/premake-core/commit/5b3497937b81e135001ac5cfe9b41cdcefa57531#diff-305eff9084f83e9096ab2d18b9815c7b52c4d3603363d3d6a27e1c85f466ec45L270, which obviously breaks the intended behaviour of https://github.com/premake/premake-core/blob/433e43bff745709cfa61b4c53a189f69da781f1d/premake5.lua#L166-L184.
@nickclark2016
We are no longer distributing the results of the package script given how trivial it is to generate the binaries manually (you probably should be doing this), and thus we really aren't maintaining the state of that script. (@samsinsane should we mark this as deprecated?)
Can you elaborate more on why you need the package action updated?
We are no longer distributing the results of the package script given how trivial it is to generate the binaries manually (you probably should be doing this), and thus we really aren't maintaining the state of that script. (@samsinsane should we mark this as deprecated?)
I honestly think this would be a really bad idea. I see it as kind of a self-hosting verification to ship project files for premake in the premake source distribution zip file.
Can you elaborate more on why you need the package action updated?
I import the source .zip that you distribute on every release into my source tree in order to be able to build it with whatever Visual Studio version the system has available.
I cannot use a released version because there is no VS2026 support.
Bootstrap.bat does not support VS2026.
Bootstrap.batdoes not support VS2026.
I've put up a PR for this.
I see it as kind of a self-hosting verification to ship project files for premake in the premake source distribution zip file.
Can you elaborate on this? From my perspective, the bootstrap files are the self-hosting verification, and this source distribution isn't really adding anything.
should we mark this as deprecated?
@nickclark2016 yeah, I think so. The goal of those generated files is for people to be able to build Premake. I don't see the need for people to do that with specific build tools, the bootstrap files should be more than enough.
