premake-core icon indicating copy to clipboard operation
premake-core copied to clipboard

add C# documentationFile feature

Open lolrobbe2 opened this issue 2 years ago • 10 comments

closes #359

What does this PR do?

this PR makes it possible to enable the xmlDocumentationFile in visualStudio C# projects.

<DocumentationFile> vs <GenerateDocumentationFile>

How does this PR change Premake's behavior?

No existing behavior should be changed, only functionality has been added.

Anything else we should know?

There are 2 ways of enabeling this new feature, either by an empty string "", or by specifying a custom dirrectory. the projectName will automaticcaly be appended to this path with the xml extension added.

when an empty string is entered the resulting filepath will be made consisting of the targetDir and the projectName with the xml extension appended to it.

this is the preffered method because visualstudio can by default only recognize when dll and xmlDocumentationFile are in the sam folder.

hacky ways that wher used before this feature solution to 359 'closed' Did you check all the boxes?

  • [x] Focus on a single fix or feature; remove any unrelated formatting or code changes
  • [x] Add unit tests showing fix or feature works; all tests pass
  • [x] Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • [x] Follow our coding conventions
  • [x] Minimize the number of commits
  • [x] Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

lolrobbe2 avatar Jun 29 '23 20:06 lolrobbe2

forgot to make a new sub branch on my fork :(

lolrobbe2 avatar Jun 29 '23 20:06 lolrobbe2

Currently away on travel. Will review when back near my computer.

nickclark2016 avatar Jul 11 '23 16:07 nickclark2016

Can somebody pls review?

lolrobbe2 avatar Sep 30 '23 20:09 lolrobbe2

Can somebody pls review?

Please go through and clean up the documentation file. Unnecessary capitalization, spacing around slashes, some wording that's uncomfortable to read. I'm happy with the code, just want the docs to be a bit better.

nickclark2016 avatar Sep 30 '23 20:09 nickclark2016

changed the documentation capitalization and wording

lolrobbe2 avatar Oct 01 '23 16:10 lolrobbe2

Missing documentation file for: documentationfile

Jarod42 avatar Oct 05 '23 14:10 Jarod42

my bad updated it and added it to the sidebar.js file. Also tested it using npm!

lolrobbe2 avatar Oct 05 '23 17:10 lolrobbe2

Can you just show me the doc mistakes because i can't see it anymore! PLS

lolrobbe2 avatar Oct 14 '23 20:10 lolrobbe2

I think the issue with the build at this point is a mismatch in capitalization in the documentation (documentationFile.md vs documentationfile.md).

nickclark2016 avatar Oct 31 '23 17:10 nickclark2016

changed the name to be documentationfile.md

lolrobbe2 avatar Oct 31 '23 20:10 lolrobbe2