signals icon indicating copy to clipboard operation
signals copied to clipboard

Add typing for effect cleanup

Open billybimbob opened this issue 3 years ago • 2 comments

The effect function signature is changed in order to more closely match the useSignalEffect signature, and also remove the ambiguity of the unknown typing.

The useSignalEffect hook also now properly passes along the cleanup function.

billybimbob avatar Oct 22 '22 01:10 billybimbob

🦋 Changeset detected

Latest commit: 50fc3e2bc092457a58351b124bf880767fa18780

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@preact/signals-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Oct 22 '22 01:10 changeset-bot[bot]

Deploy Preview for preact-signals-demo ready!

Name Link
Latest commit 50fc3e2bc092457a58351b124bf880767fa18780
Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/6406ee5539eb5600075efbc5
Deploy Preview https://deploy-preview-249--preact-signals-demo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Oct 22 '22 01:10 netlify[bot]