pre-commit.com icon indicating copy to clipboard operation
pre-commit.com copied to clipboard

Add compilerla/conventional-pre-commit to all-repos.yaml

Open thekaveman opened this issue 3 years ago • 2 comments

This closes compilerla/conventional-pre-commit#24.

@asottile I saw your comment in #684

language: script hooks miss the point of the framework as they require users to install tools outside of the framework to use them and as such I'm not allowing new ones onto the hooks page

And while conventional-pre-commit is a language: script hook, it's literally just a small shell script that does some regex against the commit message, no external tools/dependencies installed or needed. Maybe an exception can be made in this case?

Thanks for taking a look!

thekaveman avatar Jul 27 '22 21:07 thekaveman

This closes compilerla/conventional-pre-commit#24.

@asottile I saw your comment in #684

language: script hooks miss the point of the framework as they require users to install tools outside of the framework to use them and as such I'm not allowing new ones onto the hooks page

And while conventional-pre-commit is a language: script hook, it's literally just a small shell script that does some regex against the commit message, no external tools/dependencies installed or needed. Maybe an exception can be made in this case?

Thanks for taking a look!

it appears to require a modern bash as well as grep -- it would be better if implemented in python -- or really the whole script can be replaced with a pygrep regex

asottile avatar Jul 27 '22 21:07 asottile

Hello @asottile - since last week, conventional-pre-commit has been reimplemented in Python and a new version v2.0.0 published. Thank you for the suggestion!

Does it look OK to include in the list now?

thekaveman avatar Aug 04 '22 22:08 thekaveman

Hello again @asottile. Just checking one more time to see if you're willing to include our conventional-pre-commit check on the list? It has been fully re-written in Python, and I've resolved merged conflicts here on this PR. Thank you!

thekaveman avatar Nov 30 '22 23:11 thekaveman

is there a reason to use this over something more mature like gitlint ?

asottile avatar Dec 02 '22 18:12 asottile

hi -- I've edited the new pr template into the original comment -- please fill that out as well

asottile avatar Dec 15 '22 19:12 asottile