Add compilerla/conventional-pre-commit to all-repos.yaml
This closes compilerla/conventional-pre-commit#24.
@asottile I saw your comment in #684
language: scripthooks miss the point of the framework as they require users to install tools outside of the framework to use them and as such I'm not allowing new ones onto the hooks page
And while conventional-pre-commit is a language: script hook, it's literally just a small shell script that does some regex against the commit message, no external tools/dependencies installed or needed. Maybe an exception can be made in this case?
Thanks for taking a look!
This closes compilerla/conventional-pre-commit#24.
@asottile I saw your comment in #684
language: scripthooks miss the point of the framework as they require users to install tools outside of the framework to use them and as such I'm not allowing new ones onto the hooks pageAnd while
conventional-pre-commitis alanguage: scripthook, it's literally just a small shell script that does some regex against the commit message, no external tools/dependencies installed or needed. Maybe an exception can be made in this case?Thanks for taking a look!
it appears to require a modern bash as well as grep -- it would be better if implemented in python -- or really the whole script can be replaced with a pygrep regex
Hello @asottile - since last week, conventional-pre-commit has been reimplemented in Python and a new version v2.0.0 published. Thank you for the suggestion!
Does it look OK to include in the list now?
Hello again @asottile. Just checking one more time to see if you're willing to include our conventional-pre-commit check on the list? It has been fully re-written in Python, and I've resolved merged conflicts here on this PR. Thank you!
is there a reason to use this over something more mature like gitlint ?
hi -- I've edited the new pr template into the original comment -- please fill that out as well