mirrors-clang-format icon indicating copy to clipboard operation
mirrors-clang-format copied to clipboard

remove JSON since the hook breaks ipynb files

Open njzjz opened this issue 1 year ago • 2 comments

Clang-format 19 breaks ipynb files. xref: https://github.com/llvm/llvm-project/issues/110727 I can't find a way to exclude a format in pre-commit-mirror, so I remove the JSON format directly to ensure the hook doesn't break any files with the default configuration.

njzjz avatar Oct 02 '24 17:10 njzjz

seems best for now to just override this in your own config (probably with exclude: ?) assuming this will get fixed upstream

asottile avatar Oct 02 '24 18:10 asottile

The upstream has closed https://github.com/llvm/llvm-project/issues/110727 without a fix.

njzjz avatar Dec 22 '24 07:12 njzjz

https://github.com/llvm/llvm-project/pull/135137 was merged and has landed in version LLVM 21.1.0-rc1

Timple avatar Aug 12 '25 06:08 Timple