unique4j icon indicating copy to clipboard operation
unique4j copied to clipboard

Add module info and fix build for Java 9

Open vatbub opened this issue 4 years ago • 1 comments

Hi Pratanu :) I recently upgraded all my projects to the latest Java version including the introduction of modules in Java 9. To make a long story short: I had to create module-info.java files for all of my dependencies and thought to share that with you.

Before you merge though: Merging this PR makes Unique4J incompatible with Java 6, 7 and 8 and requires Java 9 or higher. If you don't care about that feel free to merge. If you do care, I would suggest to create 2 jars: One that includes the module-info.java, making Java9 users happy and one that doesn't, making support for Java 8 and lower possible.

Feel free to contact me if you have any questions :) Cheers, Vatbub

vatbub avatar Oct 12 '21 15:10 vatbub

Hi Frederik,

I apologize for the delay in my action. I thank you for your support and continued contribution to the project. It means a lot to me personally.

However, I do want to maintain compatibility starting from Java 1.6+ if possible. I will look into the solution to maintain separate builds of the project to provide support for Java 6, 7, and 8 as well as Java 9+.

Once again thank you for your contribution.

Best Regards, Pratanu Mandal

prat-man avatar Dec 01 '21 17:12 prat-man