secml-torch icon indicating copy to clipboard operation
secml-torch copied to clipboard

approve after #104 - 105 step size is not passed to optimizer in modular attack

Open maurapintor opened this issue 1 year ago • 1 comments

Changelog

Approve after #104

  • Pass input learning rate to optimizer
  • Refactor input optimizer kwargs for modular attack to be explicitly assigned to a dictionary rather than passed implicitly

Fixes #105, #106.


📚 Documentation preview 📚: https://secml-torch--107.org.readthedocs.build/en/107/

maurapintor avatar Oct 10 '24 12:10 maurapintor

Codecov Report

Attention: Patch coverage is 92.45283% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.89%. Comparing base (674b2bc) to head (3abd378).

Files with missing lines Patch % Lines
src/secmlt/optimization/constraints.py 91.30% 4 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
+ Coverage   90.79%   90.89%   +0.10%     
==========================================
  Files          49       49              
  Lines        1314     1351      +37     
==========================================
+ Hits         1193     1228      +35     
- Misses        121      123       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 10 '24 12:10 codecov[bot]