Pradeep Krishnamurthy
Pradeep Krishnamurthy
Hello, I am new to igraph and I would love to try working on this. Is this still open?
Some initial thoughts. Currently `igraph_tree(igraph_integer_t n, igraph_integer_t children, igraph_tree_mode_t type)` takes in number of nodes and edges as arguments. Could it be that I may have to introduce another signature...
oh yeah, C++ habits die hard :) I will get started with this approach for now and see if there are any suggestions to add more parameters.
From the description of the issue above `If p[i] < 0 then i has no parent...` If a node does not have a parent, will it not result in a...
In that case, calling it `igraph_tree_from_parent_vector` may not be appropriate. How about `igraph_from_parent_vector`?
Thanks for clarifying it. It's more clear now.
> Can you come up with a linear-time algorithm to verify that the graph would be cycle-free, using the parent vector? I don't have much experience with graph theory except...
> @pradkrish Let us know if you have any questions. It would be great to see this project completed. @szhorvat Apologies, I will try to allocate some time this week,...
@szhorvat I just started going through your suggested algorithm, thanks for that. A quick question, `counter` is incremented after processing each vertex but how/when to increment `visited[i]`? Apologies if it's...
@szhorvat I agree, I am currently working on the first implementation and will be able to submit a draft PR soon. We can take the rest of the discussion once...