cachecontrol icon indicating copy to clipboard operation
cachecontrol copied to clipboard

Comment about bad Expires header doesn't match semantics

Open glasser opened this issue 8 years ago • 0 comments

The code reads:

	if respHeaders.Get("Expires") != "" {
		expiresHeader, err = http.ParseTime(respHeaders.Get("Expires"))
		if err != nil {
			// sometimes servers will return `Expires: 0` or `Expires: -1` to
			// indicate expired content
			expiresHeader = time.Time{}
		}
		expiresHeader = expiresHeader.UTC()
	}

The comment says that Expires:0 or Expires:-1 means expired content. But the code doesn't treat it any differently than no Expires header.

glasser avatar Mar 21 '18 22:03 glasser