mldsa-native icon indicating copy to clipboard operation
mldsa-native copied to clipboard
Published 2 months ago • verified publisher icon pq-code-package

Fix some minor details in comments for AVX2 decompose

Open jammychiou1 opened this issue 2 months ago • 1 comments

  • The floor() in floor((f + 127) >> 7) was somewhat unecessary as the usual semantic for the right-shift operator (>>) has integer output anyway. Seeing as the right-shift operator is not used in other explanation comments, we decided to rewrite it as division by 2^7 for better consistency.
  • The bound of f1'' is correct but the proof was misleading. The new proof should be clearer.

jammychiou1 avatar Dec 01 '25 03:12 jammychiou1

I did consider addressing #654 also in this PR, but I haven't come up with a great idea for that yet...

jammychiou1 avatar Dec 01 '25 03:12 jammychiou1