mldsa-native icon indicating copy to clipboard operation
mldsa-native copied to clipboard

config.h: Align mldsa-native and mlkem-native config.h

Open willieyz opened this issue 2 months ago • 1 comments

  • Resolves: #688

  • This PR aligns the config.h differences between mldsa-native and mlkem-native.

  • For example, In mlkem-native, MLK_CONFIG_FILE is the second entry, while in mldsa-native, MLD_CONFIG_FILE was moved to the fifth position and mixed with native-backend configuration macros.

  • Aligning these discrepancies simplifies future porting and modifications, and helps prevent issues like the missing macros fixed in #686.

  • The following discrepancies also had been addressed:

    • MLD_CONFIG_MONOBUILD_KEEP_SHARED_HEADERS missing in mldsa-native, fixed.
    • MLK_CONFIG_NO_ASM_VALUE_BARRIER missing in mlkem-native, fixed in mlkem-naitve PR #1325
    • Missing FIPS 203 citation, fixed in mlkem-naitve PR #1325

willieyz avatar Nov 25 '25 09:11 willieyz

Hello, @mkannwischer , thank you for your review! I had addressed according to your comment, include:

  • Add missing MLD_CONFIG_MONOBUILD_KEEP_SHARED_HEADERS
  • Also, I had create another PR in mkem-native, added the missing MLK_CONFIG_NO_ASM_VALUE_BARRIER

willieyz avatar Nov 28 '25 09:11 willieyz