Need "stop and let ring"

[jlearman]

As implemented, the "let ring" function isn't useful for its most common usage, which is like depressing the sustain pedal on a piano, playing a chord or arpeggio, and then lifting and immediately depressing the sustain pedal at the beginning of a new chord or arpeggio.

As it's currently implemented, you can't do this with "let ring," you have to use ties (which is tedious!)

Instead, we need two attributes: "start ringing" and "continue ringing." With "start ringing," all notes would be triggered, regardless of whether the previous note or chord was letting ring. "Continue ringing" would be implemented the same as current "let ring."

The tool buttons should be "let ring" and "keep ringing."

When applying the "let ring" attribute to a selected range of chords/notes, the first one selected should be inserted as "start ringing" and the remainder should be inserted as "continue ringing."

For notation, "start ringing" would force a vertical bar showing a discontinuity in ringing, above the tab, even if the previous note or chord was ringing. Something like this:

     | let ring -----| let ring ----
E|-----------2---------------3-------|
B|-------3---------------0-----------|
G|---2---------------0---------------|

When interpreting existing tabs, the current "let ring" should be interpreted the same as before, as my suggested "continue ringing." This way, existing tabs would not be affected.

BTW with some help getting started I could probably code this.

I suspect this is what BUG: Let Ring Markers Not Implemented Correctly was really about.

[cameronwhite]

If I'm understanding the link correctly, it's just a rendering issue where the marker isn't drawn properly?

This code would be in createConnectedSymbolGroup() in painters/systemrenderer.cpp.

[jlearman]

The issue is both rendering and playback, and the playback aspect is the most important. It is not possible to have a chord ring up to a new chord and have the old chord stop just as the new chord is played (using "let ring"). Yet that is the most common use case.

[cameronwhite]

Right, that makes sense now that I've actually tried it out :) So yeah, I think having an "end let ring" marker or something along those lines would work. You could look at how bends are implemented for some inspiration, since they have a more complex system of start / hold / end events.

[jlearman]

Sure, and "end let ring" would work too. It'll be a while before I can get to this, in case it's an easy fix for anyone familiar with the code. I will post about any progress I make. Thanks for your attention on this.

[jlearman]

Hi Cameron. I'm trying to get set up to work on this, but am stymied at the CMake step. BTW, great README, very helpful. But of course there are always too many variables to cover every situation. Normally I use cygwin, but I'm not sure how to get CMake to cooperate with it, even though cygwin64/bin is in my %PATH%, and typical Linux programs like "ls" work from Windows csh. I've searched for a solution but none seem to apply. If you know a quick fix I'd appreciate that. But perhaps it would be better to just use whatever you or most people use (possibly VisualC++, assuming there's still a free version.) Also I've used Eclipse in the past and could try to set that up and perhaps CMake will then be able to generate makefiles for Eclipse. Any suggestions? BTW I'm an embedded real-time and networking product software developer for 40 years, doing mostly cross-development on Linux. I don't have experience on open source but I'd like to get started. If there's a better place for this discussion please point me, or feel free to reply by email. Thanks!

[cameronwhite]

I'd probably stick to using the free version of MSVC (which works great), or using Eclipse. I'm not sure if I can help too much with any Cygwin issues :)

[cameronwhite]

Hey Jeff, I'm not sure about the first error without seeing the rest of the log. Using either the built-in CMake or the normal Windows app should be fine though In the second error it sounds like it correctly found Boost 1.56 but didn't find any of the compiled libraries. Maybe try setting BOOST_LIBRARYDIR if those libraries do exist in your installation but aren't being picked up?

On Thu, Apr 2, 2020 at 6:30 PM Jeff Learman [email protected] wrote:

So I replaced boost with the version linked in README and didn't get as far: 1> [CMake] CMake Error at C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/Common7/IDE/CommonExtensions/Microsoft/CMake/CMake/share/cmake-3.16/Modules/FindPackageHandleStandardArgs.cmake:146 (message): 1> [CMake] Could NOT find Boost (missing: date_time filesystem iostreams 1> [CMake] program_options regex system zlib) (found suitable version "1.56.0", 1> [CMake] minimum required is "1.54.0")

I know it's not your job to sort this out but if you have any suggestions I'd appreciate it, thanks!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/powertab/powertabeditor/issues/278#issuecomment-608125221, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACKGT2UW4YSSYZSBL4G5HLRKUGZ3ANCNFSM4LFV72RQ .

[jlearman]

Thanks, found my mistake. (boost 1.56 didn't build successfully for whatever reason, and I had a typo that caused the error with the current version.) I've successfully built in MSVS using "Build all". But the Debug->Start is inactive, so how will I debug what I built? I can run it from build/x64 Debug/bin and it works. I know I can attach to it after running it, if necessary, but I bet there's a better way.

[cameronwhite]

Great! I think you need to change the startup project, which I think is in the right click menu in the project view.

[jlearman]

Thanks for the tip. That's what all the web results say too, but "set startup" doesn't appear until I find the executable and right click on it (in the solution explorer). Anyway, that works, great. Next: this PTE is rather different from the one I was using. First, the edit and playback windows are the same (great!) With the one I'd been using, playing made the window change (toolbars disappeared, etc.) and it was hard to keep my place in the song. Now it plays "in place" which is great. However, there are no toolbars for notes etc, and toolbars don't appear anywhere in the menu. Right clicking on the menu bar offers only mixer and instruments. Perhaps it's built wrong?

[jlearman]

Aha -- those were PTE 1.7 features that aren't implemented in PTE 2.

[cameronwhite]

Yeah, there are a number of UI differences from 1.7, some are intended and others are just unimplemented so far