mTRFpy icon indicating copy to clipboard operation
mTRFpy copied to clipboard
verified publisher icon powerfulbean

Error in decoder train in nested_crossval

Open powerfulbean opened this issue 1 year ago • 1 comments

The bug causes the tmin and tmax being reversed twice at this two places in the nested_crossval function:

https://github.com/powerfulbean/mTRFpy/blob/53838c8e71231e772f384e06ab322ed72d867a87/mtrf/stats.py#L124 https://github.com/powerfulbean/mTRFpy/blob/53838c8e71231e772f384e06ab322ed72d867a87/mtrf/stats.py#L269-L275

Thus the finally trained decoding model uses the wrong tmin tmax value

powerfulbean avatar Jun 19 '24 05:06 powerfulbean

Hi @OleBialas, would you like to review this commit for fixing this bug?

powerfulbean avatar Jun 19 '24 05:06 powerfulbean