observability-cli icon indicating copy to clipboard operation
observability-cli copied to clipboard

[POA-527] Add apidump flags support in ecs command

Open mudit-postman opened this issue 1 year ago • 2 comments

Plan: https://postmanlabs.atlassian.net/wiki/spaces/PO/pages/5053218962/Plan+Insights+Agent+ECS+and+other+tasks+for+supporting+50+users

  • Added support for the following eight flags: filter, host-allow, host-exclusions, interfaces, path-allow, path-exclusions, rate-limit and stats-log-delay.
  • Added new vars and persistent flags for them
  • These flags were used in makeAgentContainerDefinition() and add.go while constructing the entryPoint slice.
  • For flags which are of slice type we are adding them separately instead of joining them with comma(,)
  • These flags can also be used in all three sub-commands, i.e. add, cf-fragment and task-def

Reviewers:

  • Primary: @shreys7
  • Secondary: @mgritter

mudit-postman avatar May 06 '24 07:05 mudit-postman

How are we planning to test this @mudit-postman ?

shreys7 avatar May 06 '24 16:05 shreys7

How are we planning to test this @mudit-postman?

I am testing this by logging the flag values and using the Postman beta environment's keys. I am also commenting the final step, where the updated definition is applied.

mudit-postman avatar May 06 '24 18:05 mudit-postman