chore!: upgrade chokidar to v4
Like #501, but to v4. chokidar version 4 and up now only have 1 dependency, which is can make the install size is smaller and faster. But if you want to v5 like #501, we must drop Nodejs v18 and only support v20.19.
cc @ai
cc @RyanZim
Is there some pressing need to upgrade from v3? If not, we might as well wait until we're working on the next major release, and then upgrade to v5 directly.
Is there some pressing need to upgrade from v3? If not, we might as well wait until we're working on the next major release, and then upgrade to v5 directly.
They have remove the glob support, but we have handle it in first .then using tinyglobby. Maybe we just should upgrade the package.
Seems that the removal of glob support actually breaks things; tests are failing.
@RyanZim, i send the commit that i want to try in CI.
@RyanZim, all tests run successfully 🥳
Two problems with this approach:
- It's synchronous, which is probably slow.
- This only finds files that exist when the command is run, it doesn't watch for the creation of new files. Actually solving this problem correctly is going to be complicated; I need to think this through.
Maybe close this @RyanZim?