rsconnect-python icon indicating copy to clipboard operation
rsconnect-python copied to clipboard

publish to PyPI as `rsconnect` and `rsconnect-python`

Open edavidaja opened this issue 8 months ago • 7 comments

  • update makefile to support building wheels with a different package name
  • add a script to rewrite the package name in CI
    • uv run is used for this so that the necessary toml dependency is installed without drama

edavidaja avatar May 16 '25 15:05 edavidaja

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
5096 3828 75% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 15b5a09 by action🐍

github-actions[bot] avatar May 16 '25 15:05 github-actions[bot]

It might be worth reverting from pyproject.toml to setup.py to support this: https://github.com/posit-dev/rsconnect-python/pull/668

tdstein avatar May 16 '25 15:05 tdstein

It might be worth reverting from pyproject.toml to setup.py to support this: #668

PyPA docs suggest pyproject.toml is the way.

edavidaja avatar May 16 '25 16:05 edavidaja

It might be worth reverting from pyproject.toml to setup.py to support this: #668

PyPA docs suggest pyproject.toml is the way.

Ya, it's just unconventional for the name field in pyproject.toml to be dynamic. I guess publishing the same project under two different names is also unconventional.

Why not stop using rsconnect-python and wholly migrate to rsconnect?

tdstein avatar May 16 '25 16:05 tdstein

Why not stop using rsconnect-python and wholly migrate to rsconnect?

I think it will make sense to keep both versions on PyPI up to date until we have the opportunity to update the places where the CLI is used.

edavidaja avatar May 16 '25 16:05 edavidaja

PR Preview Action v1.6.1 :---: Preview removed because the pull request was closed. 2025-05-28 15:54 UTC

github-actions[bot] avatar May 22 '25 13:05 github-actions[bot]

Merging here appears to be blocked because of the test-connect failures and https://github.com/posit-dev/rsconnect-python/issues/649.

edavidaja avatar May 22 '25 15:05 edavidaja

matrixing the distributions job caused the branch protection rules to go out of sync (see this discussion); I've disabled just the branch protection rule requiring a passing of the distributions check, which I will re-add if I can get it to pass here or after it merges to main.

edavidaja avatar May 28 '25 15:05 edavidaja

re-enabled branch protections for the distributions jobs before merging

edavidaja avatar May 28 '25 15:05 edavidaja