ctxutil icon indicating copy to clipboard operation
ctxutil copied to clipboard

Update to go 1.14

Open hjkatz opened this issue 5 years ago • 5 comments

hjkatz avatar Mar 01 '20 00:03 hjkatz

Codecov Report

Merging #14 into master will not change coverage by %. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #14   +/-   ##
=======================================
  Coverage   79.31%   79.31%           
=======================================
  Files           2        2           
  Lines          29       29           
=======================================
  Hits           23       23           
  Misses          5        5           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a8b1603...30aeae5. Read the comment docs.

codecov[bot] avatar Mar 01 '20 00:03 codecov[bot]

Hi, What command exactly did you run in order to make this change, and why is it useful? Thanks!

posener avatar Mar 02 '20 14:03 posener

@posener I have go 1.14 installed. I changed go.mod from go 1.12 to go 1.14 and ran go build which then updated the go.mod and go.sum for me. Pretty easy to me :D

hjkatz avatar Mar 02 '20 15:03 hjkatz

Strange... why did it update all the dependencies? I can't reproduce it...

$ go version
go version go1.14 linux/amd64
$ git diff
diff --git a/go.mod b/go.mod
index 68b8d0c..25cb015 100644
--- a/go.mod
+++ b/go.mod
@@ -1,5 +1,5 @@
 module github.com/posener/ctxutil
 
-go 1.12
+go 1.14
 
 require github.com/stretchr/testify v1.3.0
$ go build ./...
$ go test ./...
PASS
ok  	github.com/posener/ctxutil	0.505s

Diff remains the same.

posener avatar Mar 02 '20 19:03 posener

Hmmm... to be 100% honest I'm not sure. What I think may have happened is that I have "update go build" or something turned on in my "vim-go" profile, and maybe internal to that the go.mod file was updated?

If you'd prefer we can not merge this PR. It's a precursor to some work I'm doing on my branch here. Which I'll submit sometime this week.

hjkatz avatar Mar 02 '20 20:03 hjkatz