flems icon indicating copy to clipboard operation
flems copied to clipboard

FLEMS is not keyboard operable; inaccessible, with non-semantic interactive elements

Open jasonday opened this issue 5 years ago • 1 comments

FLEMS makes heavy use of <div>s for interactive elements instead of taking advantage of native semantics in <a> or <button>.

Besides being inoperable (inaccessible) via the keyboard, some additional small steps should be taken to improve the accessibility of the application.

Potential improvements (not to be considered a complete list):

  • convert navigation <div>s to <a> (using <a> instead of <button> due to <nav> parent)
  • add aria-current=[true/false] to active <a>
  • for elements such as "Create new file", etc. these should be <button>s
  • the SVG icons should be in <button> and have text alternatives
  • The hamburger menu toggle should be a <button> and indicate state (aria-expanded=[true/false])
  • Inputs need labels (can be added with aria-label="")

jasonday avatar May 11 '20 13:05 jasonday

That' be great, honestly a bad oversight on my part, as I usually try to use semantically correct elements at least!

A PR would be most welcome - I don't have time available myself currently..

porsager avatar May 11 '20 13:05 porsager