python-consul2 icon indicating copy to clipboard operation
python-consul2 copied to clipboard

Enable retries in the std.py backend.

Open ShaheedHaque opened this issue 4 years ago • 3 comments

Resolves #30. This PR also:

  • Replaces the deprecated call to requests.session() with its current counterpart, requests.Session().
  • Allows arbitrary connection kwargs to be passed down, not least to allow the new retry behaviour to be overridden.

ShaheedHaque avatar Feb 20 '21 18:02 ShaheedHaque

Codecov Report

Merging #31 (8622b26) into master (7aa1ff4) will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   94.45%   94.47%   +0.01%     
==========================================
  Files           6        6              
  Lines        1840     1846       +6     
==========================================
+ Hits         1738     1744       +6     
  Misses        102      102              
Flag Coverage Δ
unittests 94.47% <100.00%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
consul/std.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7aa1ff4...8622b26. Read the comment docs.

codecov[bot] avatar Feb 20 '21 19:02 codecov[bot]

Hi, is there any chance of a release with this PR incorporated? FWIW, there is a Celery fix (https://github.com/celery/celery/issues/5605) which benefits from this, and which I had wanted to delay before this was available but I feel I need to pursue at this time.

ShaheedHaque avatar Jun 27 '21 08:06 ShaheedHaque

@poppyred Any chance of a release with this merged please?

ShaheedHaque avatar Dec 02 '22 17:12 ShaheedHaque