utils icon indicating copy to clipboard operation
utils copied to clipboard

fix: allow selective exports

Open ahmedrowaihi opened this issue 1 year ago • 3 comments

🔗 Linked issue

#43

❓ Type of change

  • [x] 🐞 Bug fix (a non-breaking change that fixes an issue)
  • [x] 👌 Enhancement (improving an existing functionality like performance)
  • [x] ✨ New feature (a non-breaking change that adds functionality)
  • [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

improve exports Resolves #43

📝 Checklist

  • [x] I have read the contribution guide.
  • [x] I have linked an issue or discussion.
  • [ ] I have updated the documentation accordingly.

ahmedrowaihi avatar Jul 02 '24 14:07 ahmedrowaihi

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Aug 31 '24 18:08 stale[bot]

Hi, @RomainLanz what's missing here?

andresgutgon avatar Sep 05 '24 10:09 andresgutgon

Hey, sorry for taking a bit too long on this PR.

I see the emitDeclarationOnly flag has been removed from the build script. Any specific reasons for doing that?

thetutlage avatar Sep 11 '24 02:09 thetutlage

Hey, sorry for taking a bit too long on this PR.

I see the emitDeclarationOnly flag has been removed from the build script. Any specific reasons for doing that?

If I remember correctly, the ts-node was not building the declarations types, since we split each file to be tree shakable with its own types, I had to remove the emitDeclarationOnl

ahmedrowaihi avatar Sep 14 '24 05:09 ahmedrowaihi

@ahmedrowaihi The build is created using tsup (JavaScript only) and the types are created using tsc. May be I am missing something, but we do not use ts-node for generating types.

Also, being tree-shakable has been the goal of this and many other packages I maintain. I strictly create them to be used within the Node.js application

thetutlage avatar Sep 14 '24 06:09 thetutlage

@thetutlage tbh, this PR took long a bit, I don't remember what exactly made me remove that flag..

Since you merged a fix, I will try to re-test my previous works that caused the error in first place to confirm if all went right after this PR .

ahmedrowaihi avatar Sep 14 '24 06:09 ahmedrowaihi

@ahmedrowaihi Sure, lemme know if you face any issues 👍

thetutlage avatar Sep 14 '24 07:09 thetutlage