pop-os
Re-apply window title on/off after screen unlocking
Before this change the window titles were still visible after unlocking the screen, even if the setting was to off.
This adds methods to pop-shell's public DBus API. Did you mean to add these methods to the extension class instead?
Before this change the window titles were still visible after unlocking the screen, even if the setting was to off.
I'm not able to recreate this issue on Pop!_OS 21.10, 20.04 LTS, or 22.04 LTS pre-release. I typically test this feature with Evolution, Thunderbird, or LibreOffice. I've tried manually locking, waiting for the screen to time out, and using a sleep command to launch a window while the screen's locked-- in all cases, the titlebar was still hidden when I unlocked the screen again. What OS and application are you seeing this behavior with?
I'm not able to recreate this issue on Pop!_OS 21.10, 20.04 LTS, or 22.04 LTS pre-release.
I'm using Ubuntu 20.04 LTS with pop-shell compiled from git master and experience it with Thunderbird for example. Most gnome apps are unaffected these days as they haven't got separate window titles anymore. I lock my screen with Ctrl-Alt-L or suspend the laptop.
This adds methods to pop-shell's public DBus API. Did you mean to add these methods to the extension class instead?
I was unsure where a DBus signal subscription would fit best. I didn't add this method to the DBus interface, so it's not a publicly (over DBus) callable method and prefixed with on... to indicate that it's an event handler. Do you think it should rather be in the Ext class?