Rust API Guidelines Checklist

[bitfl0wer]

The following checklist should be completed for a release build of Chorus. The list is sourced from here: https://rust-lang.github.io/api-guidelines/checklist.html

These so called API Guidelines should not be forced upon the project, but be just that: a set of guidelines to look up to and apply whereever it makes sense.

• Naming (crate aligns with Rust naming conventions)
  • [x] Casing conforms to RFC 430 (C-CASE)
  • [ ] Ad-hoc conversions follow as_, to_, into_ conventions (C-CONV)
  • [ ] Getter names follow Rust convention (C-GETTER)
  • [x] Methods on collections that produce iterators follow iter, iter_mut, into_iter (C-ITER)
  • [x] Iterator type names match the methods that produce them (C-ITER-TY)
  • [x] Feature names are free of placeholder words (C-FEATURE)
  • [ ] Names use a consistent word order (C-WORD-ORDER)
• Interoperability (crate interacts nicely with other library functionality)
  • [ ] Types eagerly implement common traits (C-COMMON-TRAITS)
    • Copy, Clone, Eq, PartialEq, Ord, PartialOrd, Hash, Debug, Display, Default
  • [ ] Conversions use the standard traits From, AsRef, AsMut (C-CONV-TRAITS)
  • [ ] Collections implement FromIterator and Extend (C-COLLECT)
  • [ ] Data structures implement Serde's Serialize, Deserialize (C-SERDE)
  • [ ] Types are Send and Sync where possible (C-SEND-SYNC)
  • [x] Error types are meaningful and well-behaved (C-GOOD-ERR)
  • [ ] Binary number types provide Hex, Octal, Binary formatting (C-NUM-FMT)
  • [ ] Generic reader/writer functions take R: Read and W: Write by value (C-RW-VALUE)
• Macros (crate presents well-behaved macros)
  • [ ] Input syntax is evocative of the output (C-EVOCATIVE)
  • [ ] Macros compose well with attributes (C-MACRO-ATTR)
  • [ ] Item macros work anywhere that items are allowed (C-ANYWHERE)
  • [ ] Item macros support visibility specifiers (C-MACRO-VIS)
  • [ ] Type fragments are flexible (C-MACRO-TY)
• Documentation (crate is abundantly documented)
  • [ ] Crate level docs are thorough and include examples (C-CRATE-DOC)
  • [ ] All items have a rustdoc example (C-EXAMPLE)
  • [ ] Examples use ?, not try!, not unwrap (C-QUESTION-MARK)
  • [ ] Function docs include error, panic, and safety considerations (C-FAILURE)
  • [ ] Prose contains hyperlinks to relevant things (C-LINK)
  • [ ] Cargo.toml includes all common metadata (C-METADATA)
    • authors, description, license, homepage, documentation, repository, keywords, categories
  • [ ] Release notes document all significant changes (C-RELNOTES)
  • [ ] Rustdoc does not show unhelpful implementation details (C-HIDDEN)
• Predictability (crate enables legible code that acts how it looks)
  • [ ] Smart pointers do not add inherent methods (C-SMART-PTR)
  • [ ] Conversions live on the most specific type involved (C-CONV-SPECIFIC)
  • [ ] Functions with a clear receiver are methods (C-METHOD)
  • [ ] Functions do not take out-parameters (C-NO-OUT)
  • [ ] Operator overloads are unsurprising (C-OVERLOAD)
  • [ ] Only smart pointers implement Deref and DerefMut (C-DEREF)
  • [ ] Constructors are static, inherent methods (C-CTOR)
• Flexibility (crate supports diverse real-world use cases)
  • [ ] Functions expose intermediate results to avoid duplicate work (C-INTERMEDIATE)
  • [ ] Caller decides where to copy and place data (C-CALLER-CONTROL)
  • [ ] Functions minimize assumptions about parameters by using generics (C-GENERIC)
  • [ ] Traits are object-safe if they may be useful as a trait object (C-OBJECT)
• Type safety (crate leverages the type system effectively)
  • [ ] Newtypes provide static distinctions (C-NEWTYPE)
  • [ ] Arguments convey meaning through types, not bool or Option (C-CUSTOM-TYPE)
  • [ ] Types for a set of flags are bitflags, not enums (C-BITFLAG)
  • [ ] Builders enable construction of complex values (C-BUILDER)
• Dependability (crate is unlikely to do the wrong thing)
  • [ ] Functions validate their arguments (C-VALIDATE)
  • [ ] Destructors never fail (C-DTOR-FAIL)
  • [ ] Destructors that may block have alternatives (C-DTOR-BLOCK)
• Debuggability (crate is conducive to easy debugging)
  • [ ] All public types implement Debug (C-DEBUG)
  • [x] Debug representation is never empty (C-DEBUG-NONEMPTY)
• Future proofing (crate is free to improve without breaking users' code)
  • [ ] Sealed traits protect against downstream implementations (C-SEALED)
  • [x] Structs have private fields (C-STRUCT-PRIVATE)
  • [ ] Newtypes encapsulate implementation details (C-NEWTYPE-HIDE)
  • [ ] Data structures do not duplicate derived trait bounds (C-STRUCT-BOUNDS)
• Necessities (to whom they matter, they really matter)
  • [x] Public dependencies of a stable crate are stable (C-STABLE)
  • [ ] Crate and its dependencies have a permissive license (C-PERMISSIVE)

[kozabrada123]

Updated so hyperlinks to individual guidelines work

[kozabrada123]

I might take a look at this while taking a break from voice

[kozabrada123]

https://github.com/polyphony-chat/chorus/blob/a3f8a0492b4f606adfd9b66abcf39d15ef3f3835/src/api/guilds/guilds.rs#L194-L201

This could probably be triaged; we have a lot of functions which are Something::get() or Something::get_some_stuff() which fetch resources on the server. In theory these could violate C_GETTER, but I wouldn't say they are getters, more so I would excuse the get_* since they send GET requests