Polypheny-DB icon indicating copy to clipboard operation
Polypheny-DB copied to clipboard
verified publisher icon polypheny

Allow editing settings in Query-to-File

Open vogti opened this issue 4 years ago • 8 comments

This issue requires some experience with JavaFX.

The Query-to-File interface has a config.properties file where certain settings need to be specified. It would be great to integrate these settings into the JavaFX based user interface. Some settings (like the path to fuse binary or the Polypheny-DB host address) should be configurable on startup.

vogti avatar Mar 31 '21 08:03 vogti

Hi @vogti, I'm trying to understand the requirement. Please correct me if I'm wrong.

  1. When Main program is run, JavaFX based user interface has to come up with TextFields to enter settings (host address, port, etc.)
  2. Once the fields are entered and submitted, the application will start using the given settings.
  3. Should default values be configured incase some of the fields are left blank while submitting?

PrakruthiSomashekar avatar May 22 '21 15:05 PrakruthiSomashekar

Hi @PrakruthiSomashekar, welcome to Polypheny! Would you like to take care of this issue?

  1. Exactly
  2. Exactly
  3. It makes sense to have default values. I would suggest pre-filling all input fields with these default values. It might be beneficial to keep a settings file and take the default values from that file.

It would be great if you can take care of this issue.

vogti avatar May 23 '21 21:05 vogti

Thanks @vogti! happy to contribute:) Can you please suggest parameters from this list for input?

  1. reconnectionTimeout
  2. host
  3. port
  4. fuseCapacityGB
  5. libraryPath

fyi, I've picked these from config.properties file

PrakruthiSomashekar avatar May 24 '21 03:05 PrakruthiSomashekar

Perfect :) I have assigned the issue to you. I think 2, 3 and 5 should definitely be configurable on startup. Regarding 5: The idea is that this should be determined automatically in future (trying different typical locations depending on the operating system). Nevertheless, it is always possible that the system has a very special configuration which requires manually specifying the location of the fuse binary.

vogti avatar May 24 '21 14:05 vogti

@vogti, please review the PR mentioned below. Thanks. https://github.com/polypheny/Query-to-File/pull/3

PrakruthiSomashekar avatar May 29 '21 18:05 PrakruthiSomashekar

@PrakruthiSomashekar Thank you for the PR. You may want to join our Discord server via the following link: https://discord.gg/xuBXEy4g

vogti avatar May 30 '21 14:05 vogti

Hi, This issue has not been worked in a while, could I be assigned to it if it hasn't been solved yet?

Shyamsaibethina avatar Mar 26 '24 14:03 Shyamsaibethina

Hi Shyam, yes please

On Tue, Mar 26, 2024, 7:56 AM Shyam Sai Bethina @.***> wrote:

Hi, This issue has not been worked in a while, could I be assigned to it if it hasn't been solved yet?

— Reply to this email directly, view it on GitHub https://github.com/polypheny/Polypheny-DB/issues/307#issuecomment-2020660757, or unsubscribe https://github.com/notifications/unsubscribe-auth/APARDC7CKYJ7UPOZUY2NNEDY2GECFAVCNFSM42EB4II2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBSGA3DMMBXGU3Q . You are receiving this because you were mentioned.Message ID: @.***>

PrakruthiSomashekar avatar Mar 26 '24 15:03 PrakruthiSomashekar