Improve Usability Of `CycleRange` And `RepeatRange` For Already Materialized Sequences

Open tautropfli opened this issue 2 years ago • 1 comments

Resolves #740

[ ] Fix tests
[ ] Async

Nov 30 '23 13:11 tautropfli

Open Questions

[x] Do we want this at all?
[x] This is a source breaking change as the return type for IReadOnlyCollection is different. Are we OK with this or should I rename the new overloads?

Nov 30 '23 13:11 tautropfli

I think we should include this, I think the distinction is useful and avoiding the IBuffer is certainly a good thing for the usage.

Jan 14 '25 08:01 FreeApophis

As for naming: I went with your first suggestion: {Cycle,Repeat}Materialized. I really like that its succinct and descriptive. It also gives a hint to the .Materialize() method.

Quoting from https://github.com/polyadic/funcky/issues/740#issuecomment-1838034664:

Repeat/CycleMaterialized

Repeat/CycleEager(Range, Collection)

Repeat/CycleInMemory

Repeat/Cycle

Jan 14 '25 09:01 tautropfli