SharpSerializer icon indicating copy to clipboard operation
SharpSerializer copied to clipboard

Invalid return for signed bytes in GetNumberSize

Open jtsylve opened this issue 5 years ago • 0 comments

https://github.com/polenter/SharpSerializer/blob/55782864a46016c663779688b400026bcb354d4a/SharpSerializer/Core/Binary/Elements.cs#L226

This function returns an invalid number of bytes for signed 8-bit integers. I believe the check should be referencing SByte.MinValue and SByte.MaxValue rather than byte.

jtsylve avatar Jan 25 '21 23:01 jtsylve