ember-cli-github-pages icon indicating copy to clipboard operation
ember-cli-github-pages copied to clipboard

Custom Domain Configuration Overwritten

Open allthesignals opened this issue 9 years ago • 2 comments

When using a custom domain, Github requires a CNAME file. I think this can be done through correct merging of old and new gh-pages branches, but if I understand correctly, ember github-pages:commit will destroy the branch and recreate it, removing any CNAME file that's committed to the branch. Use git push origin gh-pages:gh-pages -f with caution for this reason. Not sure if this is an issue with this add-on, but it's worth noting.

allthesignals avatar Aug 02 '16 14:08 allthesignals

Thanks for the caution. Will see if there is anything we can do.

knownasilya avatar Aug 02 '16 15:08 knownasilya

Hi,

NOTE I could resolve the issue by putting the CNAME file in the "public" folder. Then GitHub automatically recognizes and sets the custom domain, even in the Settings UI

I wanted to add my custom domain. I did it in the GitHub interface but then stupidly did a pull (as the CNAME creation commit was from the Github web UI) on my code, which "destroyed" the whole local code. As this add-on is merging many files and not leaving much on the master branch which is online, I thought creating the CNAME locally in my project files would do it, but no... The CNAME file is not being pushed to the remote master. Any ideas?

Thanks! :)

byvlstr avatar Jan 28 '17 13:01 byvlstr