api icon indicating copy to clipboard operation
api copied to clipboard

Backend for campaign reports

Open batebobo opened this issue 3 years ago • 2 comments

Summary

Implements #368

Created CRUD endpoints for campaign reports. They are part of a separate module called campaign-report, but the controller is under the campaign base route.

New entities:

  • CampaignReport
  • CampaignReportFile

Both entities support soft delete and have an owner (uploader).

Screenshot of how the new routes look like:

Screenshot 2022-12-02 at 4 35 58 PM

Todo

  • [x] Endpoint for downloading files from reports
  • [x] Tests for update service
  • [x] Tests for update controller
  • [x] Tests for delete service
  • [x] Tests for delete controller
  • [ ] Some manual testing of the whole process
  • [ ] Manual test of s3 upload/download
  • [ ] Squash migrations

batebobo avatar Dec 02 '22 14:12 batebobo

@imilchev The PR check for scanning k8s manifests with mondo showed an error that you might be interested in:

Target:     K8s Manifest dev-manifests
✕ Errors:   rpc error: code = InvalidArgument desc = asset does not match any of the activated policies

https://github.com/podkrepi-bg/api/actions/runs/3608695854/jobs/6081448709

kachar avatar Dec 04 '22 06:12 kachar

✅ Tests will run for this PR. Once they succeed it can be merged.

github-actions[bot] avatar Dec 07 '22 13:12 github-actions[bot]

@batebobo Can you please update your PR and resolve the open discussions in order to get this PR moving? :pray:

kachar avatar Feb 09 '23 16:02 kachar

closing in favor of https://github.com/podkrepi-bg/api/pull/453

igoychev avatar Apr 03 '23 06:04 igoychev