poco icon indicating copy to clipboard operation
poco copied to clipboard

Add an implementation of reactor http server

Open sky92zwq opened this issue 11 months ago • 4 comments

While developing an HTTP framework based on POCO for my client, I realized POCO didn't provide an implementation of a reactor HTTP server. So I decided to implement a reactor HTTP server. There aren't too many differences between HTTP servers and HTTP reactor servers from the user's perspective. I just added several TCP parameters and changed the HTTP server to an HTTP reactor server, which is shown in the example HTTPReactorTime.

I later found some similar work [here](https://github.com/pocoproject/poco/pull/2093). I may have duplicated some effort.

If anyone is interested in this, please let me know.

sky92zwq avatar May 15 '25 14:05 sky92zwq

Interesting, thank you. I tried to do it long time ago but it was never finished/merged.

I did not yet have time for a thorough review, but in principle I would welcome this contribution.

While at it, you may also want to replace the NotificationCenter with AsyncNotificationCenter - it's a drop-in replacement that should work out of the box. See #4414 and #4851 for the reason.

Oh yes, please write some unit tests. And see CodingStyle.

OK!

sky92zwq avatar May 16 '25 03:05 sky92zwq

@sky92zwq , many of the tests fail. Please check the logs and correct the code.

matejk avatar Jun 09 '25 10:06 matejk

@matejk I have added some commits, but I don't have a Windows compilation environment locally. May this pull request (PR) automatically trigger the workflow?

sky92zwq avatar Jun 10 '25 12:06 sky92zwq

@matejk I have added some commits, but I don't have a Windows compilation environment locally. May this pull request (PR) automatically trigger the workflow?

@sky92zwq I have approved the CI run

aleks-f avatar Jun 10 '25 12:06 aleks-f

@sky92zwq, do you have anything to add for this PR.

If not, I'd merge it to main branch.

matejk avatar Sep 29 '25 13:09 matejk

@sky92zwq, do you have anything to add for this PR.

If not, I'd merge it to main branch.

Thanks for checking in, nothing else from me right now. We can move forward and address any new cases that arise later.

sky92zwq avatar Sep 30 '25 08:09 sky92zwq