Removes defaultProperties method from various commands. Closes #6432
Removes defaultProperties method from various commands. Closes #6432
Thanks, we'll try to review it ASAP!
@SmitaNachan I added the hacktoberfest-accepted label to this PR which means that this PR will count as done for the Hacktoberfest event. So if you participate in this event it will get you unblocked and it allows us to merge this PR later when we catch up 👍
Thanks for your support and awesome contribution 👏 You Rock 🤩
Hello @Adam-it Thank you for the review comments. I will work on it. Can you please guide how can I rebase to main? Appreciate if you can provide any Git commands for the same.
Hello @Adam-it Thank you for the review comments. I will work on it. Can you please guide how can I rebase to main? Appreciate if you can provide any Git commands for the same.
@SmitaNachan Sorry for the late reply 🙏. I saw your comment but I was totally full with everything.
Sure.
- first you need to align
mainbranch on your fork withmainfrom this repo. You may do that using GitHub UI by going to your forked repo and clicking on the update button - then open your forked repo that you have locally and make sure you are on the
mainbranch. You may switch tomainbranch using thegit switch maincommand - then run standard pull
git pullso that you will download all changes from your forked repomainbranch locally. Now your local version ofmainbranch will be aligned with current state on this repo - next switch to you branch you are working on using
git switch issue-6432 - no do the rebase using
git rebase main - if during rebase you will see some conflicts please solve them manually (I usually use VS Code for that) and then once all the conflicts are sort out don't commit them but run the
git rebase --continuecommand which will continue with the rebase. - once the rebase is done you will need to push your updated branch to your repo. Since it will be different then what you have locally you will need to use the
forceoption like thisgit push --force
If you will have any kind of problem just ping me up however you want. You Rock 🤩
@pnp/cli-for-microsoft-365-maintainers due to my short brake I am unassigning myself from this one so that it may be processed by someone else
I have followed the instructions to rebase with main. However, if it does not look good, I can raise new PR.
I have followed the instructions to rebase with main. However, if it does not look good, I can raise new PR.
hi again. Happy new year. Yep most probably it does not look ok 🙂. yep lets rise a new PR. Thanks 👍
Hi @Adam-it Raised new PR https://github.com/pnp/cli-microsoft365/pull/6560. Closing this