cli-microsoft365 icon indicating copy to clipboard operation
cli-microsoft365 copied to clipboard

Adds new sample "find-obsolete-m365-groups"

Open tmaestrini opened this issue 1 year ago โ€ข 8 comments

This script is based on the original article written by Tony Redmond and was requested a long time ago in #2475. It generates a report of all M365 groups that are possibly obsolete.

Closes #2475

tmaestrini avatar Aug 14 '24 21:08 tmaestrini

Cool! Thank you @tmaestrini! We'll try to review it ASAP!

milanholemans avatar Aug 14 '24 21:08 milanholemans

Did a bunch of changes, @milanholemans โ€“ thanks for your review. ๐Ÿ™ I've really appreciated it.

tmaestrini avatar Sep 09 '24 12:09 tmaestrini

Did a bunch of changes, @milanholemans โ€“ thanks for your review. ๐Ÿ™ I've really appreciated it.

When ready, you can hit the "ready for review" at the bottom of the page, which I just did for you :)

milanholemans avatar Sep 09 '24 13:09 milanholemans

Hey @milanholemans, sorry for my confusion on my last commit (#b2ae47f). I wanted to open a new PR related to #6272.

tmaestrini avatar Sep 18 '24 20:09 tmaestrini

@milanholemans This one still waits for a review / approval.

tmaestrini avatar Sep 19 '24 20:09 tmaestrini

Hey @milanholemans, did a bunch of updatesโ€ฆ ๐Ÿ˜„ Hopefully the script is not failing anymore on your tenant. Tell me what you think. Have a good night! ๐Ÿ˜„

tmaestrini avatar Sep 25 '24 23:09 tmaestrini

Any news on this? Do you want me to change anything?

tmaestrini avatar Oct 15 '24 05:10 tmaestrini

Hi @tmaestrini will try to do another review soon. Due to lack of time this has not happened yet.

milanholemans avatar Oct 15 '24 07:10 milanholemans

Due to a change on my fork (which caused a mess in PR #6445), I had to rename the old 'main' branch. Therefore this PR was closed automatically. Could you please reopen it, @milanholemans โ€“ย or should I implement the changes and make another PR out of it?

tmaestrini avatar Oct 22 '24 21:10 tmaestrini

I cannot reopen it since your branch doesn't exist anymore.

milanholemans avatar Oct 22 '24 21:10 milanholemans

So, I will make another PR out of it.

tmaestrini avatar Oct 22 '24 21:10 tmaestrini