cli-microsoft365 icon indicating copy to clipboard operation
cli-microsoft365 copied to clipboard

Removes duplicate property for "teams tab list" command. Closes #5900

Open SmitaNachan opened this issue 1 year ago • 3 comments

Removes duplicate property called teamsAppTabId for teams tab list command. Closes #5900

SmitaNachan avatar Jul 14 '24 09:07 SmitaNachan

Thank you!

milanholemans avatar Jul 14 '24 11:07 milanholemans

Hi, since we had to align our v9 branch with the latest v8, some merge conflicts crept into your PR. Could you realign your changes with the latest v9, please? If you need any assistance, don't hesitate to ping us.

milanholemans avatar Jul 31 '24 14:07 milanholemans

Hi @SmitaNachan, could you also update the v9 upgrade guidance and recheck our sample scripts for needed changes, please? Much appreciated 🙏

milanholemans avatar Aug 12 '24 09:08 milanholemans

Due to an upcoming breaking change connected to CLI for Microsoft 365 login experience we will need to do a v9 release a bit sooner than we anticipated. Due to that we had to change the target of this PR to v10 which will be the next regular major release.

Adam-it avatar Aug 30 '24 22:08 Adam-it

Hi @SmitaNachan did you have some time to resolve the conflicts and process the last feedback?

milanholemans avatar Sep 07 '24 16:09 milanholemans

Hi @milanholemans Ready for review

SmitaNachan avatar Sep 09 '24 11:09 SmitaNachan

Hi @milanholemans Can you please review and merge, before there are any more conflicts to resolve 😁

SmitaNachan avatar Sep 12 '24 14:09 SmitaNachan

Yes, I was planning to merge it soon when merging PRs with main. 😊

milanholemans avatar Sep 12 '24 15:09 milanholemans

@SmitaNachan FYI, I rebased your PR with the latest main to save some time. Note that the branch on your local machine will be out of sync now.

milanholemans avatar Sep 20 '24 21:09 milanholemans

Merged manually, thank you!

milanholemans avatar Sep 21 '24 23:09 milanholemans