cli-microsoft365 icon indicating copy to clipboard operation
cli-microsoft365 copied to clipboard
verified publisher icon pnp

Adds 'spo folder sharinglink get' command. Closes #5962

Open nanddeepn opened this issue 1 year ago • 4 comments

Adds spo folder sharinglink get command. Closes #5962

nanddeepn avatar May 02 '24 10:05 nanddeepn

Thank you @nanddeepn, we'll try to review it ASAP.

milanholemans avatar May 02 '24 11:05 milanholemans

Hi @nanddeepn

Before I want to review the PR I have already noticed that you extended an existing util, which is a great idea as this code is being used across multiple commands.

However, something that I noticed is that you didn't write the test in the spec file for this specific util. Let's do this.

If we then use this util in our command spec file, we will simply use spo.getDriveId().resolves(...) as this code is already tested in our util file itself.

Can you fix this?

MathijsVerbeeck avatar Jun 16 '24 06:06 MathijsVerbeeck

Thank you for your review @MathijsVerbeeck I will write the test.

nanddeepn avatar Jun 18 '24 05:06 nanddeepn

Hi @MathijsVerbeeck Test cases are added.

nanddeepn avatar Jun 19 '24 17:06 nanddeepn

PR merged succesfully. Thanks for your contribution.

MathijsVerbeeck avatar Aug 14 '24 17:08 MathijsVerbeeck