Refactor `spo file`, Closes #5268

[nicodecleyre]

Opted to create a new PR since the 4 PRs are a lot of merges behind 😄.

I must say, I got this weird error, which has nothing to do with this PR:

src/utils/prompt.ts:112:5 - error TS2322: Type 'unknown' is not assignable to type 'T'.
  'T' could be instantiated with an arbitrary type which could be unrelated to 'unknown'.

But I had to define the return statement, otherwise I wouldn't get pas npm run build 🤔

Closes #5268

[milanholemans]

Hi @nicodecleyre, thanks for submitting this PR. Is there a reason why you made 1 PR for 4 issues? Usually, we handle the principle of 1 issue = 1 PR = 1 commit.

I must say, I got this weird error, which has nothing to do with this PR:

src/utils/prompt.ts:112:5 - error TS2322: Type 'unknown' is not assignable to type 'T'.
  'T' could be instantiated with an arbitrary type which could be unrelated to 'unknown'.

Strangely, we're not experiencing these issues, nor the GitHub actions. Did you reinstall your node modules using npm ci? We upgraded a few packages to a new major version with breaking changes a few weeks ago.

[nicodecleyre]

Hi @nicodecleyre, thanks for submitting this PR. Is there a reason why you made 1 PR for 4 issues? Usually, we handle the principle of 1 issue = 1 PR = 1 commit.

I must say, I got this weird error, which has nothing to do with this PR:

src/utils/prompt.ts:112:5 - error TS2322: Type 'unknown' is not assignable to type 'T'.
  'T' could be instantiated with an arbitrary type which could be unrelated to 'unknown'.

Strangely, we're not experiencing these issues, nor the GitHub actions. Did you reinstall your node modules using npm ci? We upgraded a few packages to a new major version with breaking changes a few weeks ago.

Hi Milan, yes, it was decided to merge it into one PR : https://github.com/pnp/cli-microsoft365/issues/4531#issuecomment-2078359738

[milanholemans]

In that case, I suggest that you merge the 4 issues into 1 issue and close the 3 others.

Did a reinstall fix your prompt util?

[nicodecleyre]

In that case, I suggest that you merge the 4 issues into 1 issue and close the 3 others.

Done! 😄

Did a reinstall fix your prompt util?

Absolutely, thank you for your help!

[Jwaegebaert]

Hey @nicodecleyre, pardon for the late reply. There seem to be some conflicts, would you mind taking a look at them?

[nicodecleyre]

Hey @nicodecleyre, pardon for the late reply. There seem to be some conflicts, would you mind taking a look at them?

Hi there! No problem at all. I've merged the pr with the latest main.

Kind regards!