cli-microsoft365 icon indicating copy to clipboard operation
cli-microsoft365 copied to clipboard
verified publisher icon pnp

Remove the `overwrite` option from `github workflow add` command

Open Adam-it opened this issue 2 years ago • 2 comments

I got a good comment in #5763

About the --overwrite option: is that really necessary? It seems to me that when you deploy an application using ci/cd, it should always overwrite the existing package...

It makes total sense that a CI/CD pipline is rather made to continuously redeploy and overwrite existing package with new one. We should remove this option from the command and make overwrite default.

This is a breaking change and should target v8

Adam-it avatar Jan 07 '24 23:01 Adam-it

Good point. Let's deprecate it already, with a warning, and remove in v8.

waldekmastykarz avatar Jan 14 '24 08:01 waldekmastykarz

@waldekmastykarz good point. I added an issue for that

Adam-it avatar Jan 15 '24 22:01 Adam-it

Since we have v8 branch we may now start working on it! Let's get this 🚢 and Let's put CLI to the 🚀🌙

Adam-it avatar Jul 07 '24 01:07 Adam-it

Can I work on it?

SmitaNachan avatar Jul 14 '24 09:07 SmitaNachan

PR merged

Adam-it avatar Aug 13 '24 22:08 Adam-it