cli-microsoft365 Enhances `m365 login` to ensure that the user is signed in, Closes #5217

Closes #5217

Dec 12 '23 18:12 nicodecleyre

Hi @nicodecleyre, before we review this: let's make sure we add the option to the documentation as well.

Dec 12 '23 18:12 martinlingstuyl

Hey @nicodecleyre, are you still working on this?

Mar 23 '24 09:03 waldekmastykarz

Hi @waldekmastykarz, I certainly am, I'm awaiting your response in hope to get some guidance 🙏 https://github.com/pnp/cli-microsoft365/pull/5717#discussion_r1477366137

Mar 23 '24 10:03 nicodecleyre

Hi @waldekmastykarz, I certainly am, I'm awaiting your response in hope to get some guidance 🙏 #5717 (comment)

Ah sorry, missed it. My bad. Thanks for pointing it out

Mar 23 '24 10:03 waldekmastykarz

Hi @waldekmastykarz, changed the approach for the tests. Can you give it another look and give feedback if you think that this approach would prove that the code is actually working?

Thank you!

Mar 24 '24 15:03 nicodecleyre

Hey @nicodecleyre, just wanted to check if I you're still working on it and if I can clarify anything 😊

Apr 13 '24 06:04 waldekmastykarz

Hey @nicodecleyre, just wanted to check if I you're still working on it and if I can clarify anything 😊

Hi @waldekmastykarz, thx for following up! Your explanation helped to understand how to approach the tests differently. These have now been implemented with a precise assert and 100% code coverage. Can you take another look whenever you have time?

Thx in advance!

Apr 13 '24 20:04 nicodecleyre

Hi @waldekmastykarz,

Thank you for you review! I hope I understood you correctly. Can you subject this PR to another review please?

Thx!

Apr 29 '24 20:04 nicodecleyre

I think we're getting closer @nicodecleyre. Let's check a few things before we proceed

May 05 '24 10:05 waldekmastykarz