cli-microsoft365 icon indicating copy to clipboard operation
cli-microsoft365 copied to clipboard
verified publisher icon pnp

Adds 'spo file roleinheritance reset' command. Closes #3595

Open nanddeepn opened this issue 3 years ago • 2 comments

Adds spo file roleinheritance reset command. Closes #3595

nanddeepn avatar Sep 12 '22 14:09 nanddeepn

Thank you for your amazing work @nanddeepn 👏 We'll review it asap!

milanholemans avatar Sep 12 '22 15:09 milanholemans

Hi @nanddeepn

I see that your command still uses the old commandAction with callback function. Could you rebase again from main and refactor it to async/await please? Else we'll get build errors 😊

Thank you for your awesome work!

milanholemans avatar Sep 22 '22 06:09 milanholemans

Hi @milanholemans Refactored the code to async/await. Thank you.

nanddeepn avatar Sep 25 '22 13:09 nanddeepn

@pnp/cli-for-microsoft-365-maintainers 2nd thought is always appreciated 🙌

milanholemans avatar Sep 26 '22 21:09 milanholemans

Hi @milanholemans Thank you for your review comments! 🧡 I hope, I was able to address those in the PR. 😊

nanddeepn avatar Sep 27 '22 11:09 nanddeepn

Hi @milanholemans Thank you for your review comments! 🧡 I hope, I was able to address those in the PR. 😊

Thank you for the changes @nanddeepn, great work! I'll have a second look ASAP 😊

milanholemans avatar Sep 27 '22 11:09 milanholemans

@nanddeepn are you participating for hacktoberfest? 😊

milanholemans avatar Sep 27 '22 18:09 milanholemans

Hi @milanholemans Yes, I will be participating for hacktoberfest.

nanddeepn avatar Sep 28 '22 06:09 nanddeepn

Merged manually, thank you for your contribution!

milanholemans avatar Oct 03 '22 21:10 milanholemans