cli-microsoft365 icon indicating copy to clipboard operation
cli-microsoft365 copied to clipboard

Extend docs with a Team page. Closes #2166

Open Jwaegebaert opened this issue 3 years ago • 1 comments

Closes #2166

What can you find within this PR.

I added a new JavaScript file generate-team-cards.js that will generate all the user cards within the new Team page. Within this file there are 2 variables defined in the beginnig. The first one contains all the maintainers and the second one the contributors. This way we can easily add new contributors and maintainers to our documentation by adding them to these variables.

Some of the contributors are missing additional information like github profile and/or company name etc... I couldn't find any additional information on them.

Next on, like mentioned in the issue. The cards are fully reconstructed like the ones on the PnP site.

Preview screenshots:

afbeelding

afbeelding

Jwaegebaert avatar Aug 08 '22 21:08 Jwaegebaert

Great work @Jwaegebaert 👏 We will review shortly.

garrytrinder avatar Aug 09 '22 09:08 garrytrinder

Definitely can do that but in relation towards the cards from the PnP site, the CLI ones will be a bit different then.

Example of the PnP site with some height difference. afbeelding

Jwaegebaert avatar Aug 12 '22 07:08 Jwaegebaert

This is fine. I also do not like the height differences of the PnP site cards :).

I think it could be solved with a simple min-height parameter

plamber avatar Aug 12 '22 07:08 plamber

Okaj, I will make the adjustment shortly 😄

Jwaegebaert avatar Aug 12 '22 07:08 Jwaegebaert

Hi @Jwaegebaert Can I please request you to correct my Twitter handler as SmitaNachan 😄 Thank you

SmitaNachan avatar Aug 12 '22 14:08 SmitaNachan

@SmitaNachan , will do. Currently I'm on holiday, so I will fix it next week.

Jwaegebaert avatar Aug 12 '22 21:08 Jwaegebaert

Thank you. Great work. Manually merged.

I fixed @SmitaNachan handle.

Cheers

plamber avatar Aug 14 '22 07:08 plamber