react-spring icon indicating copy to clipboard operation
react-spring copied to clipboard

fix(#2173): add explicit dep for @react-spring/rafz for yarn and pnpm

Open wegry opened this issue 1 year ago • 6 comments

Why

#2173 points out that TypeScript types for @react-spring/web depend on @react-spring/rafz. In Yarn 4 with PnP enabled (and maybe pnpm with no-hoist enabled), this requires the user to explicitly import or override dependencies for @react-spring/web.

What

This PR adds the TypeScript dependency explicitly.

Checklist

  • [X] Ready to be merged

Closes #2173

wegry avatar Apr 08 '24 12:04 wegry

⚠️ No Changeset found

Latest commit: 3f557f6d080c4089ac95e8a562a35a72bca0af01

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Apr 08 '24 12:04 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-spring ❌ Failed (Inspect) Apr 10, 2024 5:18pm

vercel[bot] avatar Apr 08 '24 12:04 vercel[bot]

Thanks for the contribution! You need to run yarn to update the lockfile :)

joshuaellis avatar Apr 09 '24 08:04 joshuaellis

You need to run yarn to update the lockfile :)

@joshuaellis done.

wegry avatar Apr 09 '24 11:04 wegry

⚠️ No Changeset found

Latest commit: 3f557f6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

did you see this message? :)

joshuaellis avatar Apr 10 '24 17:04 joshuaellis

@joshuaellis I had not. See 3e3dbac. Not sure why style checks are failing now for files I didn't change though.

wegry avatar Apr 10 '24 17:04 wegry