leva icon indicating copy to clipboard operation
leva copied to clipboard

fix: move 'why-did-you-render' to devDependencies

Open jonlambert opened this issue 3 years ago • 3 comments

Hey! Firstly, awesome work on Leva. Awesome package.

Fairly likely that this is providing some service that I've not managed to catch from a quick look through the code, but I can't see if there's a reason why @welldone-software/why-did-you-render is a production dependency rather than a dev dep? 🙂

Was throwing conflict warnings in a project so I thought I'd check and open this PR in case it was helpful!

jonlambert avatar Aug 05 '22 10:08 jonlambert

⚠️ No Changeset found

Latest commit: 4454dc3ed72f00d5a92d5ae6884553d08dbc60ee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Aug 05 '22 10:08 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
leva ✅ Ready (Inspect) Visit Preview Aug 5, 2022 at 10:13AM (UTC)

vercel[bot] avatar Aug 05 '22 10:08 vercel[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4454dc3ed72f00d5a92d5ae6884553d08dbc60ee:

Sandbox Source
leva-minimal Configuration
leva-busy Configuration
leva-scroll Configuration
leva-advanced-panels Configuration
leva-ui Configuration
leva-theme Configuration
leva-transient Configuration
leva-plugin-plot Configuration
leva-plugin-bezier Configuration
leva-plugin-spring Configuration
leva-custom-plugin Configuration

codesandbox-ci[bot] avatar Aug 05 '22 10:08 codesandbox-ci[bot]

Fair enough! Sorry for the long wait, I'll merge this now

dbismut avatar Oct 20 '22 05:10 dbismut