ecctrl icon indicating copy to clipboard operation
ecctrl copied to clipboard

Fix EcctrlJoystick when "strictNullChecks": true on tsconfig

Open joaomelorodrigues opened this issue 1 year ago • 2 comments

joaomelorodrigues avatar May 16 '24 08:05 joaomelorodrigues

Thanks for your help, @cyango ! However, setting strictNullChecks to true would cause more ts bugs in the majority of Ecctrl. This package wasn't initially designed for TypeScript. I'll need more time to review and fix all the issues.

ErdongChen-Andrew avatar May 17 '24 00:05 ErdongChen-Andrew

Oh ok, let me know then. Meanwhile i keep using version 1.077

joaomelorodrigues avatar May 17 '24 09:05 joaomelorodrigues

@cyango I had the same issue, and used your code in a forked example of this repo, but also had to add:

@types/draco3d
debounce 
@types/eslint
@types/estree
@types/json-schema
@types/json5
@types/offscreencanvas
@types/parse-json
@types/prop-types
@types/react-reconciler
@types/webxr
@types/ws

to my own repo

timhc22 avatar Aug 24 '24 22:08 timhc22