typescript-tools.nvim icon indicating copy to clipboard operation
typescript-tools.nvim copied to clipboard

Make node executable configurable

Open aromeronavia opened this issue 2 years ago • 4 comments

In this particular line, it's using either a cmd.exe for windows or node. I would love to have a settings for using bun as my node executable or any other custom-version node.

https://github.com/pmizio/typescript-tools.nvim/blob/master/lua/typescript-tools/process.lua#L126

I can jump into it! I would benefit from having something like this, just want to triage it first to see if that's on your roadmap

aromeronavia avatar Feb 07 '24 05:02 aromeronavia

As far as I know running tsserver in node vs bun gives no performance benefits. Even creator of bun himself stated this in some post when bun and it's performance discussion showed up(I'll try to find it).

So, no I didn't have it on my roadmap. But, I don't mind to have it as option in config defaulting into node. It should be easy to implement so if you want to jump in and do that, I'll gladly accept your pr.

pmizio avatar Feb 08 '24 06:02 pmizio

Great! I'll find some time in the upcoming days, thanks for the feedback!

I saw that tweet you are mentioning. For some reason at my team, by using bun we are experiencing less LSP crashes, a faster startup time and an improvement in autocomplete responses.

aromeronavia avatar Feb 14 '24 05:02 aromeronavia

Related with bun: https://github.com/williamboman/mason.nvim/issues/1035

PixsaOJ avatar Sep 10 '24 20:09 PixsaOJ

@pmizio Could you reference a place where we could add custom command arguments and prefixs? I am looking at internal_commands.lua

Edit: My bad somebody made PR:

https://github.com/pmizio/typescript-tools.nvim/pull/237

PixsaOJ avatar Sep 10 '24 20:09 PixsaOJ