Incorrect variables for include directories are used in the build process

Open mslusarz opened this issue 6 years ago • 3 comments

Only $(PKG)_INCLUDEDIR and $(PKG)_INCLUDE_DIRS exist, but many CMakeFiles in libpmemobj-cpp use $(PKG)_INCLUDE_DIR.

See https://cmake.org/cmake/help/v3.6/module/FindPkgConfig.html#command:pkg_check_modules

Apr 25 '19 14:04 mslusarz

Actually _INCLUDE_DIR can exist, it's dependent on the package. For example curses sets INCLUDE_DIR for backward compatibility (https://cmake.org/cmake/help/latest/module/FindCurses.html).

Jun 26 '19 10:06 igchor

I would make sure all our variables in CMake are setup properly, before closing this issue.

Jul 07 '20 09:07 lukaszstolarczuk