plumed2 icon indicating copy to clipboard operation
plumed2 copied to clipboard

PDB functions not accepting negative residue numbers

Open carlocamilloni opened this issue 1 year ago • 1 comments

@gtribello @GiovanniBussi @maxbonomi @Iximiel we were doing some test using SAXS on PDB constructs and we found out that PLUMED PDB functions do not accept negative residue numbers becasue they all take unsigned in input. For example getResidueRange(unsigned start, unsigned end) ecc. I cannot remember if there was any reason for this. If not we would see if it is possible to modify this behavior. Do you expect this to break somethign else?

carlocamilloni avatar Jun 26 '24 15:06 carlocamilloni

For atom numbers I think we have to stick to positive (>=1).

For residue numbers I don't know any reason to limit to positive. However, we should check carefully all places where residues are entered. A possible tricky thing is what happens if we allow users to use ranges (1-10 is clear, what about -10--1? Maybe it works, but I am afraid it could not).

GiovanniBussi avatar Jun 26 '24 15:06 GiovanniBussi