tag icon indicating copy to clipboard operation
tag copied to clipboard

Fix search option

Open stonebuzz opened this issue 2 months ago • 0 comments

Checklist before requesting a review

Please delete options that are not relevant.

  • [ ] I have performed a self-review of my code.
  • [ ] I have added tests (when available) that prove my fix is effective or that my feature works.
  • [ ] I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • [ ] This change requires a documentation update.

Description

  • It fixes #306

Fix

[2025-11-20 13:12:21] glpi.CRITICAL:   *** Uncaught PHP Exception Twig\Error\RuntimeError: "An exception has been thrown during the rendering of a template ("Syntax error") in "pages/generic_list.html.twig" at line 37." at generic_list.html.twig line 37
  Backtrace :
  ./templates/pages/generic_list.html.twig:37        
  ./vendor/twig/twig/src/Template.php:358            Twig\Template->yield()
  ./vendor/twig/twig/src/Template.php:373            Twig\Template->display()
  ./vendor/twig/twig/src/TemplateWrapper.php:51      Twig\Template->render()
  .../Glpi/Application/View/TemplateRenderer.php:170 Twig\TemplateWrapper->render()
  ./src/Glpi/Controller/AbstractController.php:68    Glpi\Application\View\TemplateRenderer->render()
  ./src/Glpi/Controller/GenericListController.php:51 Glpi\Controller\AbstractController->render()
  ./vendor/symfony/http-kernel/HttpKernel.php:181    Glpi\Controller\GenericListController->__invoke()
  ./vendor/symfony/http-kernel/HttpKernel.php:76     Symfony\Component\HttpKernel\HttpKernel->handleRaw()
  ./vendor/symfony/http-kernel/Kernel.php:197        Symfony\Component\HttpKernel\HttpKernel->handle()
  ./public/index.php:70                              Symfony\Component\HttpKernel\Kernel->handle()
  Previous: Syntax error
  ...machine/safe/lib/Exceptions/JsonException.php:9 
  .../thecodingmachine/safe/lib/special_cases.php:39 Safe\Exceptions\JsonException::createFromPhpError()
  ./plugins/tag/inc/tag.class.php:419                Safe\json_decode()
  ./src/Glpi/Search/Provider/SQLProvider.php:6831    PluginTagTag::getSpecificValueToDisplay()
  ./src/Glpi/Search/Provider/SQLProvider.php:5219    Glpi\Search\Provider\SQLProvider::giveItem()
  ./src/Glpi/Search/SearchEngine.php:655             Glpi\Search\Provider\SQLProvider::constructData()
  ./src/Glpi/Search/SearchEngine.php:670             Glpi\Search\SearchEngine::getData()
  ./src/Glpi/Search/SearchEngine.php:627             Glpi\Search\SearchEngine::showOutput()
  :                                                  Glpi\Search\SearchEngine::show()
  .../Application/View/Extension/PhpExtension.php:93 call_user_func_array()
  ...ates/72/722a3c7a40c9f1bcde4c398da1fc7ffa.php:55 Glpi\Application\View\Extension\PhpExtension->call()
  ./vendor/twig/twig/src/Template.php:402            __TwigTemplate_baadd8d18b40ec41429ef27e8e60eebe->doDisplay()
  ./vendor/twig/twig/src/Template.php:358            Twig\Template->yield()
  ./vendor/twig/twig/src/Template.php:373            Twig\Template->display()
  ./vendor/twig/twig/src/TemplateWrapper.php:51      Twig\Template->render()
  .../Glpi/Application/View/TemplateRenderer.php:170 Twig\TemplateWrapper->render()
  ./src/Glpi/Controller/AbstractController.php:68    Glpi\Application\View\TemplateRenderer->render()
  ./src/Glpi/Controller/GenericListController.php:51 Glpi\Controller\AbstractController->render()
  ./vendor/symfony/http-kernel/HttpKernel.php:181    Glpi\Controller\GenericListController->__invoke()
  ./vendor/symfony/http-kernel/HttpKernel.php:76     Symfony\Component\HttpKernel\HttpKernel->handleRaw()
  ./vendor/symfony/http-kernel/Kernel.php:197        Symfony\Component\HttpKernel\HttpKernel->handle()
  ./public/index.php:70                              Symfony\Component\HttpKernel\Kernel->handle()

as $values[$field] (value from 'type_menu' column ) can be empty (no specific associated item linked t otag)

Screenshots (if appropriate):

stonebuzz avatar Nov 20 '25 13:11 stonebuzz