fields icon indicating copy to clipboard operation
fields copied to clipboard

[Feature] Notification target ticket

Open JeremieMercier opened this issue 9 months ago • 3 comments

Checklist before requesting a review

Please delete options that are not relevant.

  • [x] I have performed a self-review of my code.
  • [ ] I have added tests (when available) that prove my fix is effective or that my feature works.
  • [ ] I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • [x] This change requires a documentation update.

Description

This PR adds support for injecting dynamic custom field values into GLPI's ticket notification templates.

  • Depends on #941

JeremieMercier avatar Apr 11 '25 18:04 JeremieMercier

@JeremieMercier, To automatically fix issues detected by php-cs-fixer, first install the dependencies using Composer (if not already done):

composer install

Then run the fixer:

vendor/bin/php-cs-fixer fix .

As for PHPStan, there is no automatic fixer. However, you can analyze the code locally and inspect the reported issues using:

vendor/bin/phpstan analyze

Rom1-B avatar Apr 17 '25 06:04 Rom1-B

I have updated the PR with the latest changes from PR 941

JeremieMercier avatar Apr 17 '25 13:04 JeremieMercier

Hi @JeremieMercier

The feature you are proposing is very interesting and introduces a significant feature. . To ensure its smooth integration and functionality, we must be extremely vigilant. This means we need to "lock down" our testing to guarantee that everything works as expected.

All types of fields must be tested from a tag on a notification to ensure the rendering of values from the plugin (as well as the label, which depends on the user's language, such as FR/EN, etc.).

stonebuzz avatar May 20 '25 07:05 stonebuzz