plotly.py
plotly.py copied to clipboard
fix typo in error message formatting in process_args_into_dataframe
Code PR
- [x] I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of
plotly.graph_objects, my modifications concern thecodegenfiles and not generated files. - [ ] I have added tests (if submitting a new feature or correcting a bug) or modified existing tests.
- [ ] For a new feature, I have added documentation examples in an existing or new tutorial notebook (please see the doc checklist as well).
- [ ] I have added a CHANGELOG entry if fixing/changing/adding anything substantial.
- [x] For a new feature or a change in behaviour, I have updated the relevant docstrings in the code to describe the feature or behaviour (please see the doc checklist as well).
A couple issues when following contributing.md:
- the python packages appear to be floating and installed
numpyat >=2, which did not work; the tests failed with deprecation ofnp.NaN. I'd submit a change but worry about how much backwards compatibility withnumpythat might break so instead I forced my numpy down to <2. - There were also some dependencies for tests which were not included in
optional_requirements.txt: these included at least scikit-image statsmodels polars orca -- I resorted to testing justpackages/python/plotly/plotly/tests/test_coreto work around this. - Finally, one tests wrote out the file
packages/python/plotly/plotly/tests/test_orca/test_sg_scraper.htmlwhich was not git ignored -- though as a new contributor, I'm not sure if I missed something, the file isn't meant to be ignored, or if it's alright to add an ignore for it.
Thanks in advance for the review @marthacryan