plotly.py icon indicating copy to clipboard operation
plotly.py copied to clipboard

fix typo in error message formatting in process_args_into_dataframe

Open ndrwrbgs opened this issue 1 year ago • 1 comments

Code PR

  • [x] I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the codegen files and not generated files.
  • [ ] I have added tests (if submitting a new feature or correcting a bug) or modified existing tests.
  • [ ] For a new feature, I have added documentation examples in an existing or new tutorial notebook (please see the doc checklist as well).
  • [ ] I have added a CHANGELOG entry if fixing/changing/adding anything substantial.
  • [x] For a new feature or a change in behaviour, I have updated the relevant docstrings in the code to describe the feature or behaviour (please see the doc checklist as well).

A couple issues when following contributing.md:

  1. the python packages appear to be floating and installed numpy at >=2, which did not work; the tests failed with deprecation of np.NaN. I'd submit a change but worry about how much backwards compatibility with numpy that might break so instead I forced my numpy down to <2.
  2. There were also some dependencies for tests which were not included in optional_requirements.txt: these included at least scikit-image statsmodels polars orca -- I resorted to testing just packages/python/plotly/plotly/tests/test_core to work around this.
  3. Finally, one tests wrote out the file packages/python/plotly/plotly/tests/test_orca/test_sg_scraper.html which was not git ignored -- though as a new contributor, I'm not sure if I missed something, the file isn't meant to be ignored, or if it's alright to add an ignore for it.

ndrwrbgs avatar Jul 09 '24 04:07 ndrwrbgs

Thanks in advance for the review @marthacryan

ndrwrbgs avatar Aug 25 '24 22:08 ndrwrbgs